[Crypto]: Replace scrypt.c
with crypto_scrypt
implemented in Rust
#3489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3391
The problem in the mentioned issue is related to an incorrect working of the
scrypt
function.When we compile WalletCore using Xcode 14.3.1 in Release mode,
scrypt
starts computing weird password hashes. Moreover, it seems to change a global context, so each function call with the same arguments returns a predictable but different hash.Metrics are provided at #3482 (comment)
How to test
Run C++, Rust, iOS, Android, WASM tests
Types of changes
Add
crypto_scrypt
FFI function in Rust that is inspired by RustCrypto/scrypt and using RustCrypto/pbkdf2 (most likely not audited) and RustCrypto/salsa20 (not audited, has a usage warning).Checklist
If you're adding a new blockchain