Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sec]: Zeroize mnemonic #3520

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Sec]: Zeroize mnemonic #3520

merged 1 commit into from
Oct 30, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Zeroize mnemonic passphrase allocated on heap.

How to test

Run C++, iOS, Android tests.
Use memory dump tools to make sure if the mnemonic does not present in the memory.

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@Milerius Milerius merged commit b391586 into master Oct 30, 2023
12 checks passed
@Milerius Milerius deleted the s/zeroize-mnemonic branch October 30, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamafab lamafab lamafab approved these changes

@Milerius Milerius Milerius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshiotomakan @Milerius @lamafab