Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCH]: Fix Transaction Planning #4118

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[BCH]: Fix Transaction Planning #4118

merged 2 commits into from
Nov 20, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

Description

This PR fixes AnySigner.plan() for BitcoinCash through BitcoinV2 protocol.

How to test

Run Rust tests

Types of changes

Fix tw_bitcoincash::Entry

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

Binary size comparison

➡️ aarch64-apple-ios:

- 12.29 MB
+ 12.29 MB 	 +5 KB

➡️ aarch64-apple-ios-sim:

- 12.29 MB
+ 12.29 MB 	 +5 KB

➡️ aarch64-linux-android:

- 15.80 MB
+ 15.81 MB 	 +8 KB

➡️ armv7-linux-androideabi:

- 13.48 MB
+ 13.48 MB 	 +6 KB

➡️ wasm32-unknown-emscripten:

- 11.21 MB
+ 11.21 MB 	 +6 KB

@satoshiotomakan satoshiotomakan merged commit e34e9ba into master Nov 20, 2024
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/bitcoincash-plan branch November 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant