Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solana]: Support compiling a transaction with existing external signature #4193

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Jan 2, 2025

Description

A DApp may generate a transaction that requires two signatures: Sign A (generated by the DApp) and Sign B (generated by the user).
Case 1: The DApp requires Signature B from the user first, then combines it with Signature A, and broadcasts the transaction.
Case 2: The DApp fills the transaction with Signature A first, then requires Signature B from the user, and broadcasts the transaction.

Case 1 has been supported in PR #4143.
Case 2 will be supported in this PR.

How to test

Run Rust, C++, iOS, Android tests

Types of changes

No breaking changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @10gic, thanks for the PR! Only one minor note

rust/chains/tw_solana/src/compiler.rs Outdated Show resolved Hide resolved
@satoshiotomakan satoshiotomakan merged commit 376076e into trustwallet:master Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants