feat(heap): Component based heap #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heap data internals from Value and rest of crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of but mostly forgetting the VM from #21 I create an initial heap implementation and a bunch of examples of how this heap is used, in rough terms anyway.
Basically: Each type of thing lives in its own heap vector, objects here, strings there, arrays over there etc. At least right now eg. an Array has its array data and then a "pointer" (index) to an object data. It would be possible to inline the object data into the array data which would lessen the pressure on the object vector but it would bring usually-unnecessary (hopefully) data into the array data. An array is usually there for its elements (indexed properties), so keeping just those "close by" improves cache locality. If we brought in the object properties together then we'd probably push stuff out of L1 cache.
Anyway, fun stuff.