-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): Complete GlobalDeclarationInstantiation and partially handle EvaluateCall #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
force-pushed
the
feat/vm-call-expression
branch
from
January 24, 2024 14:35
7e0a74e
to
184d9d7
Compare
aapoalas
changed the title
Feat/vm call expression
feat(vm): Complete GlobalDeclarationInstantiation and partially handle EvaluateCall
Jan 25, 2024
…peration doc comment titles and links
aapoalas
force-pushed
the
feat/vm-call-expression
branch
from
January 25, 2024 16:26
bc51b2a
to
9c223a2
Compare
sno2
previously approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uncommented unsafe
s make me nervous, but I think it's fine for now since it runs. Left a few comments, none of which are completely necessary. Nice work, LGTM
nova_vm/src/ecmascript/abstract_operations/operations_on_objects.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/execution/environments/global_environment.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carter Snook <[email protected]>
Co-authored-by: Carter Snook <[email protected]>
Co-authored-by: Carter Snook <[email protected]>
sno2
previously approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully complete the GlobalDeclarationInstantiation spec abstract operation used for script evaluation and create a partial handling of the EvaluateCall syntax directed operation / bytecode instruction.