Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): Complete GlobalDeclarationInstantiation and partially handle EvaluateCall #85

Merged
merged 22 commits into from
Jan 25, 2024

Conversation

aapoalas
Copy link
Collaborator

@aapoalas aapoalas commented Jan 22, 2024

Fully complete the GlobalDeclarationInstantiation spec abstract operation used for script evaluation and create a partial handling of the EvaluateCall syntax directed operation / bytecode instruction.

@aapoalas aapoalas changed the title Feat/vm call expression feat(vm): Complete GlobalDeclarationInstantiation and partially handle EvaluateCall Jan 25, 2024
@aapoalas aapoalas marked this pull request as ready for review January 25, 2024 16:25
sno2
sno2 previously approved these changes Jan 25, 2024
Copy link
Contributor

@sno2 sno2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uncommented unsafes make me nervous, but I think it's fine for now since it runs. Left a few comments, none of which are completely necessary. Nice work, LGTM

Co-authored-by: Carter Snook <[email protected]>
aapoalas and others added 3 commits January 25, 2024 21:19
Co-authored-by: Carter Snook <[email protected]>
Co-authored-by: Carter Snook <[email protected]>
sno2
sno2 previously approved these changes Jan 25, 2024
@aapoalas aapoalas merged commit 3a47cfa into main Jan 25, 2024
1 check passed
@aapoalas aapoalas deleted the feat/vm-call-expression branch January 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants