Default filename parameter for save file dialog #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
|
This looks good all in all. I just added a small change request to the PR. If you can resolve that we will merge it for the next release. |
|
Can't found that change. Anyway i turned on "Allow edits by maintainers" option for my branch. |
philippjbauer
requested changes
Oct 10, 2024
| @@ -2459,7 +2459,7 @@ public void SendNotification(string title, string body) | |||
| /// <param name="defaultPath">Default path. Defaults to <see cref="Environment.SpecialFolder.MyDocuments"/></param> | |||
| /// <param name="filters">Array of <see cref="Extensions"/> for filtering.</param> | |||
| /// <returns></returns> | |||
| public string ShowSaveFile(string title = "Save file", string defaultPath = null, (string Name, string[] Extensions)[] filters = null) | |||
There was a problem hiding this comment.
Can you add this back in as a method overload and call the new signature, supplying a null value for the new defaultFileName parameter?
Sorry about that. I forgot to submit the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default filename parameter for save file dialog.
This is a solution for issue #140.
Supplied together with PR for Photino.Native (tryphotino/photino.Native#140).