add support for the units selected in the display #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tschundler Will you update your repository for this year? Do you think we could add this PR to it? |
Yes, I'll update for this year. I didn't see the notification for this last year. When golden spike data is released, I'll merge with upstream Meshtastic, and after addressing those conflicts will merge this. (probably around August 1st) |
|
Ok great! |
tschundler
added a commit
that referenced
this pull request
Jul 25, 2024
Not exactly the same change; the interim number must be feet for use with golden spike data as-is.
|
I created a new branch, https://github.com/tschundler/Meshtastic-device/tree/brc-2024 and included a commit to do this. I tested and get a reasonable 432km to the man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm glad I've found your project it'll be so useful on playa.
I however use metric units and I figured rather than just changing the variables for me we could make it compatible with the units settings of the display.