Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(di): value defined by Constant and Value decorator are now available on constructor #2812

Merged
merged 8 commits into from
Sep 8, 2024

Conversation

Romakita
Copy link
Collaborator

@Romakita Romakita commented Sep 2, 2024

Information

Type Breaking change
Feature Yes

This feature needs to have useDefineForClassFields: false in tsconfig.json

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Romakita Romakita marked this pull request as draft September 2, 2024 18:05
@Romakita Romakita force-pushed the feat-inject-decorators-using-global-context branch 5 times, most recently from 9bd760e to 9babaf6 Compare September 7, 2024 17:01
@Romakita Romakita force-pushed the feat-inject-decorators-using-global-context branch from ec15788 to 4de548d Compare September 8, 2024 09:04
@Romakita Romakita changed the base branch from production to alpha September 8, 2024 11:08
@Romakita Romakita marked this pull request as ready for review September 8, 2024 11:09
…e or value in injectable property

value defined by Constant and Value decorator are now available on constructor
injectable services on property are now available in the constructor

BREAKING-CHANGE: This change require to set `    "useDefineForClassFields": false` in your tsconfig
Some DI methods are removed like bindInjectableProperties() which is not necessary.
…e type signature of container typegraphql definition
…t used method

BREAKING-CHANGE: remove PlatformBuilder.addComponents() method which isn't used method
…vailable from @tsed/di

BREAKING-CHANGE: getInterceptorOptions must be imported from @tsed/di instead of @tsed/platform-cache
@Romakita Romakita force-pushed the feat-inject-decorators-using-global-context branch from 4de548d to 28c04ec Compare September 8, 2024 17:28
@Romakita Romakita merged commit d35a703 into alpha Sep 8, 2024
2 checks passed
@Romakita Romakita deleted the feat-inject-decorators-using-global-context branch September 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant