Insert merged lineage #2300
Merged
Insert merged lineage #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyhhon: Factor out common logic from merge_ancestors and merge_two ancestors
Abstract out details of adding in merged lineage
jeromekelleher
force-pushed
the
insert-merged-lineage
branch
from
0b10eeb
to
d7b9eec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 90.94% 91.03% +0.09%
==========================================
Files 20 20
Lines 12043 12023 -20
Branches 2450 2439 -11
==========================================
- Hits 10952 10945 -7
+ Misses 602 595 -7
+ Partials 489 483 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Low coverage in diff can't be helped here, a large fraction of the update is unreachable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on #2294
Factor out a bunch of repetitive and complicated code from the key merge_ancestors functions.