Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure all docs into JupyterBook format #329

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Nov 3, 2023

And fix some internal references

@hyanwong hyanwong force-pushed the docs-rejig branch 2 times, most recently from e1ba8f0 to 7feb389 Compare November 6, 2023 17:38
@hyanwong
Copy link
Member Author

hyanwong commented Nov 6, 2023

For docs to appear on the tskit web site, need to add tsdate into https://github.com/tskit-dev/tskit-site/blob/main/.github/workflows/build-deploy.yml

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues with the mergify config, otherwise great.
I haven't been line by line through all the docs files - I assume there are no changes there that aren't just for JB.
Thanks @hyanwong I'll get on with the site action.

.mergify.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
@hyanwong
Copy link
Member Author

hyanwong commented Nov 7, 2023

Thanks for looking @benjeffery - I have changed the mergify.yl file - I'm not 100% sure what I'm doing there, so I hope I have it right. I'm pretty sure that the unit tests are run when PRs are made, but I'm assuming mergify is looking at something else.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there - the tsdate repo just runs tests on circleCI not GitHub actions hence the removal of all these lines.

.mergify.yml Outdated Show resolved Hide resolved
@benjeffery benjeffery merged commit b03502b into tskit-dev:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants