Qqplot 2sample #138
Merged
Qqplot 2sample #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daikitag
force-pushed
the
qqplot_2sample
branch
from
b6d5c33
to
52debf6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 342 342
Branches 48 48
=========================================
Hits 342 342 ☔ View full report in Codecov by Sentry. |
daikitag
force-pushed
the
qqplot_2sample
branch
from
52debf6
to
b176f68
Compare
verification.py
Outdated
| @@ -71,6 +71,18 @@ def _plot_qq_compare(self, data1, data1_name, data2, data2_name): | |||
| pyplot.savefig(f, dpi=72) | |||
| pyplot.close("all") | |||
|
|
|||
| sns.kdeplot(data1, color="b", fill=True, legend=False) | |||
There was a problem hiding this comment.
Could these be shown on the same axes in different colours? The point is to compare the distributions, right?
daikitag
force-pushed
the
qqplot_2sample
branch
from
b176f68
to
b83cce8
Compare
Add density plots when plotting qqplots to compare two data.
daikitag
force-pushed
the
qqplot_2sample
branch
from
b83cce8
to
7004b8a
Compare
jeromekelleher
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add density plots when plotting qqplots to compare two data.