Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genetic value computation #62

Merged
merged 1 commit into from
Aug 11, 2023
Merged

genetic value computation #62

merged 1 commit into from
Aug 11, 2023

Conversation

daikitag
Copy link
Collaborator

@daikitag daikitag commented Aug 7, 2023

Compute genetic values from effect size dataframe

@daikitag daikitag mentioned this pull request Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #62 (95d7782) into main (d35fc4e) will increase coverage by 1.08%.
The diff coverage is 100.00%.

❗ Current head 95d7782 differs from pull request most recent head fc5e27b. Consider uploading reports for the commit fc5e27b to get more accurate results

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   94.10%   95.18%   +1.08%     
==========================================
  Files           6        7       +1     
  Lines         339      395      +56     
  Branches       50       57       +7     
==========================================
+ Hits          319      376      +57     
+ Misses         19       18       -1     
  Partials        1        1              
Files Changed Coverage Δ
tstrait/provenance.py 100.00% <ø> (+25.00%) ⬆️
tstrait/__init__.py 100.00% <100.00%> (ø)
tstrait/base.py 100.00% <100.00%> (ø)
tstrait/genetic_value.py 100.00% <100.00%> (ø)
tstrait/simulate_effect_size.py 98.57% <100.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Some great use of numpy functions here 👍

@jeromekelleher
Copy link
Member

Just needs a rebase and squash I think, the history is a bit convoluted

Compute genetic values from effect size dataframe
@daikitag
Copy link
Collaborator Author

Really nice! Some great use of numpy functions here 👍

Thank you for your feedback Jerome!

@jeromekelleher jeromekelleher merged commit 404cc98 into tskit-dev:main Aug 11, 2023
9 checks passed
@daikitag daikitag deleted the sim-genetic branch August 11, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants