Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE: Function names #73

Merged
merged 1 commit into from
Aug 22, 2023
Merged

CODE: Function names #73

merged 1 commit into from
Aug 22, 2023

Conversation

daikitag
Copy link
Collaborator

Put underscore in front of functions and classes that are hidden.

@daikitag daikitag added this to the 0.0.1 release milestone Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #73 (2423c32) into main (3df3922) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          295       298    +3     
  Branches        28        30    +2     
=========================================
+ Hits           295       298    +3     
Files Changed Coverage Δ
tstrait/__init__.py 100.00% <ø> (ø)
tstrait/simulate_phenotype.py 100.00% <ø> (ø)
tstrait/trait_model.py 100.00% <ø> (ø)
tstrait/genetic_value.py 100.00% <100.00%> (ø)
tstrait/simulate_effect_size.py 100.00% <100.00%> (ø)
tstrait/simulate_environment.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Put underscore in front of functions and classes that are hidden. Also remove stats_tests.py, as statistical tests are implemented as part of unit tests.
@daikitag
Copy link
Collaborator Author

Docs will fail, but new documentation will be built based on these functions.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jeromekelleher jeromekelleher merged commit 6acdc9b into tskit-dev:main Aug 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants