Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminology to reflect ARG paper #274

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Jun 20, 2024

Fixes #273

@hyanwong hyanwong force-pushed the arg-wording branch 2 times, most recently from 4ae1d19 to 02a3ef7 Compare June 20, 2024 13:29
@jeromekelleher
Copy link
Member

Happy to merge, not sure why build is failing?

@hyanwong
Copy link
Member Author

hyanwong commented Jun 20, 2024

Looks like lots of "ImportError: numpy.core.multiarray failed to import" errors when trying to import tskit, msprime, etc.. I suspect it might be numpy 2.0 related? We could wait until all that's settled down, then retry.

@jeromekelleher
Copy link
Member

Yep, that's what it is

@jeromekelleher
Copy link
Member

Best wait, hopefully will have binary compatible packages in a few days

@hyanwong
Copy link
Member Author

Hooray, this now passes. Not that the ARG paper is out, let's merge it for consistency.

@jeromekelleher jeromekelleher merged commit 126cbd5 into tskit-dev:main Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit ARG descriptions and calling syntax
2 participants