Use exist_ok=False for os.makedirs
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for your contribution! I'm a little confused on what you're attempting to accomplish here. Do you think you could describe what behavior you're trying to fix or change? |
|
Hi @tsroten. The issue is when you have multiple processes using the same file cache. In that case, you end up with race conditions, where both processes are trying to create the same file and you receive a |
tsroten
requested changes
Feb 21, 2024
Co-authored-by: Thomas Roten <[email protected]>
|
@dimitris-flyr This is now released in version 0.5.2, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/os.html#os.makedirs
We receive
FileExistsErrorwhen multiple processes use the same file cache