Skip to content

Commit

Permalink
[Spaces/Public/Management] Reorganize components out of edit_space (e…
Browse files Browse the repository at this point in the history
…lastic#191792)

In a new version of the Spaces and Roles UX, the Edit Space UX and
Create Space UX will be a separate screen and page component. This is
enables the Edit Space UX to have a form for assigning roles to the
space, which creates more complexity and introduces the need for us to
go to a tabbed interface when editing a space.

This commit organizes components that will be reused across the
different page components of Create Space and Edit Space.

## Summary

Reorganized files to ease future work
  • Loading branch information
tsullivan authored Aug 30, 2024
1 parent 41e7e3d commit b886fe8
Show file tree
Hide file tree
Showing 31 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import type { EnabledFeatures } from '@kbn/spaces-plugin/public/management/edit_space/enabled_features';
import type { EnabledFeatures } from '@kbn/spaces-plugin/public/management/components/enabled_features';
import {
ResponseActionTypes,
ResponseActionTypesEnum,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ import { FormattedMessage } from '@kbn/i18n-react';

import { CustomizeSpaceAvatar } from './customize_space_avatar';
import { getSpaceAvatarComponent, getSpaceColor, getSpaceInitials } from '../../../space_avatar';
import type { FormValues } from '../../edit_space/manage_space_page';
import type { SpaceValidator } from '../../lib';
import { toSpaceIdentifier } from '../../lib';
import type { FormValues } from '../manage_space_page';
import { SectionPanel } from '../section_panel';

// No need to wrap LazySpaceAvatar in an error boundary, because it is one of the first chunks loaded when opening Kibana.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import { i18n } from '@kbn/i18n';

import { MAX_SPACE_INITIALS } from '../../../../common';
import { encode, imageTypes } from '../../../../common/lib/dataurl';
import type { FormValues } from '../../edit_space/manage_space_page';
import type { SpaceValidator } from '../../lib';
import type { FormValues } from '../manage_space_page';

interface Props {
space: FormValues;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import type { NotificationsStart } from '@kbn/core/public';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';

import { ConfirmDeleteModal } from './confirm_delete_modal';
import type { Space } from '../../../common';
import type { SpacesManager } from '../../spaces_manager';
import { ConfirmDeleteModal } from '../components/confirm_delete_modal';

interface Props {
style?: 'button' | 'icon';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ import { KibanaFeature } from '@kbn/features-plugin/public';
import { featuresPluginMock } from '@kbn/features-plugin/public/mocks';
import { findTestSubject, mountWithIntl } from '@kbn/test-jest-helpers';

import { ConfirmAlterActiveSpaceModal } from './confirm_alter_active_space_modal';
import { EnabledFeatures } from './enabled_features';
import { ManageSpacePage } from './manage_space_page';
import type { SolutionView, Space } from '../../../common/types/latest';
import { EventTracker } from '../../analytics';
import type { SpacesManager } from '../../spaces_manager';
import { spacesManagerMock } from '../../spaces_manager/mocks';
import { ConfirmAlterActiveSpaceModal } from '../components/confirm_alter_active_space_modal';
import { EnabledFeatures } from '../components/enabled_features';

// To be resolved by EUI team.
// https://github.com/elastic/eui/issues/3712
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@ import type { FeaturesPluginStart, KibanaFeature } from '@kbn/features-plugin/pu
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';

import { ConfirmAlterActiveSpaceModal } from './confirm_alter_active_space_modal';
import { CustomizeSpace } from './customize_space';
import { DeleteSpacesButton } from './delete_spaces_button';
import { EnabledFeatures } from './enabled_features';
import { SolutionView } from './solution_view';
import type { Space } from '../../../common';
import { isReservedSpace } from '../../../common';
import type { EventTracker } from '../../analytics';
import { getSpacesFeatureDescription } from '../../constants';
import { getSpaceColor, getSpaceInitials } from '../../space_avatar';
import type { SpacesManager } from '../../spaces_manager';
import { UnauthorizedPrompt } from '../components';
import { ConfirmAlterActiveSpaceModal } from '../components/confirm_alter_active_space_modal';
import { CustomizeSpace } from '../components/customize_space';
import { DeleteSpacesButton } from '../components/delete_spaces_button';
import { EnabledFeatures } from '../components/enabled_features';
import { SolutionView } from '../components/solution_view';
import { toSpaceIdentifier } from '../lib';
import { SpaceValidator } from '../lib/validate_space';

Expand Down

0 comments on commit b886fe8

Please sign in to comment.