Compatibility with submodules and docstrings #18
Conversation
| @@ -10,8 +10,6 @@ package: | |||
| source: | |||
| git_url: https://github.com/tudat-team/tudatpy.git | |||
| git_rev: {{ git_rev }} | |||
| patches: | |||
| - use_sysconfig_for_python_paths.patch | |||
There was a problem hiding this comment.
Is Python 3.12 passing without this now, or has this been added to the tudatpy source?
There was a problem hiding this comment.
I increased the minimum required CMake version for tudatpy to be able to use the "new" method for finding Python, so we don't need that part of the YACMASetup script anymore
There was a problem hiding this comment.
When you say 3.12 I assume you refer to the one that is used to generate the macOS distributions, right? Because we only support 3.9 to 3.11 right now (until I figure out why pydantic does not support 3.12 or why are we forcing the use of a version that doesn't)
There was a problem hiding this comment.
Sorry, I'm not up to date on what you're working towards with CMake at the moment, but I added that patch so that Python 3.12 was supported by tudatpy and found using YACMA.
Feel free to provide links and a summary of what you're fixing.
| - python -c "from tudatpy.io import get_resource_path; print(get_resource_path())" | ||
| - python -c "from tudatpy.io import save2txt" |
There was a problem hiding this comment.
I know someone is going to be happy about this change. @DominicDirkx
What do you mean? @geoffreygarrett |
You pinged me with a review request, unless that was a mistake. I was suggesting you let the tests run on Azure so I can do that. |
Goal
To make the current
developbranch of the feedstock compatible with tudat-team/tudatpy#159.Changelog
meta.yamlTutdat & TudatPy versions
The setup in this PR has been tested for