fix double layer destruction in gdal postgis and exit failure if post…

…gis connection failed
tudelft3d · Sep 4, 2018 · fa1e31e · fa1e31e
1 parent 1e80a52
commit fa1e31e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Map3d.cpp b/src/Map3d.cpp
@@ -423,7 +423,7 @@ bool Map3d::get_pdok_output(std::string filename) {
       OGRLayer *layer = create_gdal_layer(driver, tmpFilename, layername, attributes, f->get_class() == BUILDING);
       if (layer == NULL) {
         std::cerr << "ERROR: Cannot open database '" + filename + "' for writing" << std::endl;
-        close_gdal_resources(driver, layers);
+        GDALClose(driver);
         return false;
       }
       layers.emplace(layername, layer);
@@ -440,7 +440,7 @@ bool Map3d::get_pdok_output(std::string filename) {
 
     f->get_shape(layers[layername], true, extraAttribute);
   }
-  close_gdal_resources(driver, layers);
+  GDALClose(driver);
   return true;
 #endif
 }

diff --git a/src/main.cpp b/src/main.cpp
@@ -684,6 +684,7 @@ int main(int argc, const char * argv[]) {
     }
     else {
       std::cerr << "ERROR: Writing features failed for " << format << ". Aborting.\n";
+      return EXIT_FAILURE;
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -684,6 +684,7 @@ int main(int argc, const char * argv[]) { @@
         }
         else {
           std::cerr << "ERROR: Writing features failed for " << format << ". Aborting.\n";
+          return EXIT_FAILURE;
         }
       }
@@ Expand Down @@