Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when pets at dead players return after end camouflage #1296

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix bug when pets at dead players return after end camouflage #1296

merged 4 commits into from
Sep 6, 2023

Conversation

Tommy-XL
Copy link
Contributor

@Tommy-XL Tommy-XL commented Sep 5, 2023

Note: If a player dead during camouflage, his pet disappears, but after the end of camouflage, the pet will return back

@Hyz-sui Hyz-sui added the bug/バグ修正 Something isn't working label Sep 6, 2023
Hyz-sui
Hyz-sui reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@Hyz-sui Hyz-sui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!!

  • Since the Do() method is no longer used, using HarmonyLib is no longer necessary.

Modules/Camouflague.cs Outdated Show resolved Hide resolved
Modules/Camouflague.cs Show resolved Hide resolved
@Tommy-XL
Copy link
Contributor Author

Tommy-XL commented Sep 6, 2023

Oops made a typo in the commit

@Hyz-sui
Copy link
Collaborator

Hyz-sui commented Sep 6, 2023

Well, no problem😄

@Hyz-sui Hyz-sui changed the base branch from main to temp/1296 September 6, 2023 15:23
@Hyz-sui Hyz-sui merged commit a9a2b97 into tukasa0001:temp/1296 Sep 6, 2023
@Tommy-XL Tommy-XL deleted the FixPetReturnAfterCamouflage branch September 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyz-sui Hyz-sui Hyz-sui approved these changes

Assignees
No one assigned
Labels
bug/バグ修正 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tommy-XL @Hyz-sui