Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug / Vented player stuck for others players after desync "BootFromVent" #1315

Conversation

Tommy-XL
Copy link
Contributor

@Tommy-XL Tommy-XL commented May 13, 2024

Fixed an issue where the player got stuck for some players after desync BootFromVent and null errors appeared in the logs (Unity errors)

Instead of using desync BootFromVent and using id vent 127 it is better to use RpcBootFromVent, it prevents getting stuck

Example bug:
image

After fix:
image

@Tommy-XL
Copy link
Contributor Author

Tommy-XL commented May 13, 2024

Idk why the code was originally made this way, but apparently in older versions AU the BootFromVent code worked completely differently

@Tommy-XL Tommy-XL changed the title Fix bug / Players stuck for others players after desync "BootFromVent" Fix bug / Vented player stuck for others players after desync "BootFromVent" May 13, 2024
@Hyz-sui
Copy link
Collaborator

Hyz-sui commented May 14, 2024

Thank you!
It has been fixed in the dev version, but our fix uses a bit different way so we'll consider which is better.
It used to work better because an exception was thrown at just the right place on vanillas.

@Hyz-sui Hyz-sui added the bug/バグ修正 Something isn't working label May 14, 2024
@Hyz-sui
Copy link
Collaborator

Hyz-sui commented May 17, 2024

Our fix delays the RpcBootFromVent by 0.5 seconds.
I asked the implementer and confirmed that it is better, so I will close this PR.
Thank you for your contribution!

(CC: @kou-hetare)

@Hyz-sui Hyz-sui closed this May 17, 2024
@Tommy-XL
Copy link
Contributor Author

Ok

@Tommy-XL Tommy-XL deleted the FixPlayerStuckAfterDesyncBootFromVent branch May 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/バグ修正 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants