Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected count for writeListStart #658

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

nlitsme
Copy link
Contributor

@nlitsme nlitsme commented Sep 12, 2024

writeAttributes omits empty items, but the list size was still set to the full length of Attrs.
added countAttributes to count the non-empty Attributes.

This solves some protocol errors.

Copy link
Contributor

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@mateusfmello mateusfmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tulir tulir merged commit 061c065 into tulir:main Sep 17, 2024
2 checks passed
kenshin6x pushed a commit to thiagosm/whatsmeow that referenced this pull request Sep 17, 2024
crazycodezombie pushed a commit to crazycodezombie/whatsmeow that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants