feat: add GroupJoinApprovalMode/GroupMemberAddMode/GroupUpdateDescrip… #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusfmello
suggested changes
Sep 19, 2024
|
Sorry, I rolled back the module name |
There was a problem hiding this comment.
If you change this error message:
if mode != "on" && mode != "off" {
return fmt.Errorf("invalid mode %q", mode)
}
Therefore:
if mode != "on" && mode != "off" {
return errors.New("invalid mode, must be 'on' or 'off'")
}
It will help the user to better understand the error.
Leaving it the same as the GroupMemberAddMode method
tulir
reviewed
Sep 24, 2024
group.go
Outdated
|
|
||
| // GroupMemberAddMode sets the group member add mode to 'admin_add' or 'all_member_add'. | ||
| func (cli *Client) GroupMemberAddMode(jid types.JID, mode string) error { | ||
| if mode != "admin_add" && mode != "all_member_add" { |
There was a problem hiding this comment.
This needs to use the existing type rather than a string https://pkg.go.dev/go.mau.fi/whatsmeow/types#GroupMemberAddMode
There was a problem hiding this comment.
it's done.
group.go
Outdated
|
|
||
| // GroupJoinApprovalMode sets the group join approval mode to 'on' or 'off'. | ||
| func (cli *Client) GroupJoinApprovalMode(jid types.JID, mode string) error { | ||
| if mode != "on" && mode != "off" { |
There was a problem hiding this comment.
This looks like it should be a boolean rather than a string
tulir
approved these changes
Sep 24, 2024
tulir
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new functionality that enables group join approval (GroupJoinApprovalMode), control over how new members are added (GroupMemberAddMode), and the ability to update group descriptions (GroupUpdateDescription).