Adds cache to store expensive frame data #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Classes/Camera/CameraController.swift # Classes/Camera/MediaArchiver.swift # Classes/Editor/EditorViewController.swift # Classes/Preview/CameraPreviewViewController.swift
- Remove drawing canvas changes - Move Archive - Add CodingKeys - Move Frames
Reduces the impact of `EditorViewController.addCarouselDefaultColors` on time when switching frames.
bjtitus
requested review from
danielebogo
and removed request for
danielebogo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cache which
EditorViewControllercan use to store expensive values calculated from media. For now, that consists of the media's dominant color data used byEditorViewController.addCarouselDefaultColors(). This dramatically speeds up switching between media. Eventually, I think we could investigate speeding up the dominant color process, but we don't need to redo this each time when switching.Testing
Multiple Exports,Camera MetalandMetal Filtersflags.Profiling
Before
A single frame switch takes > 1s:
After
Much shorter durations seen in the graph:
A single frame switch takes ~ 100ms:
Time Profiler Traces
BeforeCache.trace.zip
AfterCache.trace.zip