Fixed #16 Added option to configure mapping of fields in SinkRecord to CQL columns #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| case _ => Seq( | ||
| "com.typesafe.scala-logging" %% "scala-logging" % "3.1.0", | ||
| "org.scala-lang.modules" %% "scala-parser-combinators" % "1.0.4" |
There was a problem hiding this comment.
Using this for JSON parsing. It comes with scala-core for 2.10.
There was a problem hiding this comment.
What about when using scala 2.11, the norm? and 2.12 coming?
There was a problem hiding this comment.
Since it comes with 2.10 or less, I added this dependency only for scala versions >= 11.
|
@aaruna I want to wait on this because my PR coming is a huge change. It will be easier to integrate this after, thanks. |
aaruna
changed the title
| @@ -123,6 +125,9 @@ object TaskConfig { | |||
| final val SinkConsistency: Key = "cassandra.sink.consistency" | |||
| final val DefaultSinkConsistency = ConsistencyLevel.LOCAL_QUORUM | |||
|
|
|||
| final val FieldMapping: Key = "cassandra.sink.field.mapping" | |||
| final val DefaultFieldMapping = Map.empty[String, Any] | |||
There was a problem hiding this comment.
I don't see how this could be anything other than Map[String,String] from the overarching config in the api so
final val DefaultFieldMapping = Map.empty[String, String]
|
@helena I have updated the PR. |
…kRecord to CQL columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16