Skip to content

Commit

Permalink
Merge pull request #52 from turbo-llm/off_clearml_artifacts_uploading
Browse files Browse the repository at this point in the history
Off clearml aritfacts uploading
  • Loading branch information
alekseymalakhov11 authored Nov 3, 2024
2 parents e75a7eb + 9e98712 commit a66986f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 4 additions & 1 deletion turbo_alignment/common/logging/clearml.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@

def create_clearml_task(parameters: ClearMLSettings, config: dict[str, Any] | None = None) -> Task:
clearml_task = Task.init(
task_name=parameters.task_name, project_name=parameters.project_name, continue_last_task=True # FIXME?
task_name=parameters.task_name,
project_name=parameters.project_name,
continue_last_task=True,
output_uri=False,
)

clearml_task.connect_configuration(config, name='HyperParameters')
Expand Down
5 changes: 1 addition & 4 deletions turbo_alignment/common/tf/callbacks/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,7 @@ def _log(self, logs: dict[str, Any], state: TrainerState) -> None:
self._wandb_run.log({**rewritten_logs, 'train/global_step': state.global_step}, step=state.global_step)

def _fix_table_type(self, logs: dict[str, Any]) -> dict[str, Any]:
return {
k: wandb.Table(dataframe=v) if isinstance(v, pd.DataFrame) else v
for k, v in logs.items()
}
return {k: wandb.Table(dataframe=v) if isinstance(v, pd.DataFrame) else v for k, v in logs.items()}


class ClearMLLoggingCallback(LoggingCallback):
Expand Down

0 comments on commit a66986f

Please sign in to comment.