Nca pair loss #65
Merged
Nca pair loss #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix the linters before merging, everything else looks good |
alekseymalakhov11
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Linters don't work because this branch has an old version of the transformers library, which does not have the num_items_in_batch argument. Nevertheless, the target branch has a newer version of the transformers library with this argument, so you can ignore this linter problem. Approved!
oltsy
merged commit 12b29d4
into
alekseymalakhov11-add-flash-attention2
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.