Skip to content

Commit

Permalink
Add documentation to require setting delimiter for matching based on …
Browse files Browse the repository at this point in the history
…LIST
  • Loading branch information
ading1977 committed Jun 17, 2019
1 parent 422cae3 commit a471aa4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/builder/merged_entity_meta_data_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ type ReturnType string
const (
MergedEntityMetadata_STRING ReturnType = "String"
MergedEntityMetadata_LIST_STRING ReturnType = "List"
DEFAULT_DELIMITER string = ","
)

var (
Expand Down Expand Up @@ -335,6 +334,9 @@ func (builder *MergedEntityMetadataBuilder) KeepInTopology(keepInTopology bool)

// InternalMatchingType specifies the type of the matching metadata to look for in the internal entity.
// Currently only MergedEntityMetadata_STRING and MergedEntityMetadata_LIST_STRING are supported.
// If MergedEntityMetadata_LIST_STRING is specified, InternalMatchingPropertyWithDelimiter() or
// InternalMatchingFieldWitDelimiter() must be called to explicitly set the delimiter that separates
// the list of strings
func (builder *MergedEntityMetadataBuilder) InternalMatchingType(returnType ReturnType) *MergedEntityMetadataBuilder {
builder.matchingMetadataBuilder.internalReturnType = returnType
return builder
Expand Down Expand Up @@ -401,6 +403,9 @@ func (builder *MergedEntityMetadataBuilder) InternalMatchingOid() *MergedEntityM

// ExternalMatchingType specifies the type of the matching metadata to look for in the external entity.
// Currently only MergedEntityMetadata_STRING and MergedEntityMetadata_LIST_STRING are supported.
// If MergedEntityMetadata_LIST_STRING is specified, ExternalMatchingPropertyWithDelimiter() or
// ExternalMatchingFieldWithDelimiter() must be called to explicitly set the delimiter that separates
// the list of strings
func (builder *MergedEntityMetadataBuilder) ExternalMatchingType(returnType ReturnType) *MergedEntityMetadataBuilder {

builder.matchingMetadataBuilder.externalReturnType = returnType
Expand Down

0 comments on commit a471aa4

Please sign in to comment.