Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

677 update m2 projects #683

Merged
merged 2 commits into from
Apr 21, 2023
Merged

677 update m2 projects #683

merged 2 commits into from
Apr 21, 2023

Conversation

CassandraGoose
Copy link
Contributor

@CassandraGoose CassandraGoose commented Apr 21, 2023

Description of changes made
this pr closes #677

  • ensure what's cooking part 1, overlook, travel tracker, and fit lit part 1 all have the competency example of "Application has a robust and thorough test suite" with out the additional details regarding all functions that do not update the dom.
    - I did not change anything in Fit-Lit-Part-2 or Whats-Cookin-Part-2 because those don't have functional updates yet.
  • ensure what's cooking part 1, overlook, and travel tracker all have a testing guideline section that matches fitlit part 1
  • update the rubric style of what's cooking part 1 and flashcards to have dropdowns.

Motivation for any changes
See issue for motivations

Questions that you have for a reviewer

  • did I miss anything?

…e the same testing verbiage; update wc1 o and tt to update testing rubric section; update wc1 to have dropdowns in rubric
@CassandraGoose CassandraGoose changed the base branch from gh-pages to development April 21, 2023 21:34
@CassandraGoose CassandraGoose marked this pull request as ready for review April 21, 2023 21:36
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for sage-cupcake-e1a0c3 ready!

Name Link
🔨 Latest commit e72853e
🔍 Latest deploy log https://app.netlify.com/sites/sage-cupcake-e1a0c3/deploys/6443051136ceac0008baf6ef
😎 Deploy Preview https://deploy-preview-683--sage-cupcake-e1a0c3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hfaerber hfaerber merged commit 7c57199 into development Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor updates to already updated M2 projects
2 participants