Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recaptcha2 plugin support #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TomRichter
Copy link

Added recaptcha2 plugin support so that using preregister and recaptcha2 in tandem works correctly. Without this change, recaptcha2's CAPTCHA is ignored during registration and preregister's own CAPTCHA may appear alongside it, depending on settings.

I also attempted to update the localized admin panel strings to acknowledge recaptcha2 as a valid option, but I don't speak any of these languages and couldn't make a educated guess for Japanese. It might be worth getting an actual speaker to proofread them, if possible.

The previous pull request introduced a bug that caused the original captcha plugin to not work correctly, resulting in builtin always being substituted in. This version does not have that problem.

@turnermm
Copy link
Owner

It will take a little while for me to get to this. In the meantime I am adding a link on the preregister plugin page to your update for users of recaptcha2:
https://www.dokuwiki.org/plugin:preregister#recaptcha2
This way it will, hopefully, get used and tested, and I will have a chance to familiarize myself with recaptcha2.

@TomRichter
Copy link
Author

Thanks for adding the link. I'm using this branch on my own wiki, so I'll hopefully catch any remaining bugs or weirdness. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants