WIP: Add /tournaments/:id/stages endpoint #70

Thor77 · 2019-10-10T17:32:59Z

houndci-bot · 2019-10-10T17:33:04Z

app/controllers/stages_controller.rb

@@ -35,6 +36,29 @@ def update
    end
  end

+  def index


Metrics/CyclomaticComplexity: Cyclomatic complexity for index is too high. [7/6]
Metrics/PerceivedComplexity: Perceived complexity for index is too high. [10/7]

Malaber · 2019-10-10T17:45:03Z

app/controllers/stages_controller.rb

+        else
+          render json: { error: 'There\'s no group stage for this tournament' }, status: :not_found
+        end
+      elsif level_param.to_i.to_s == level_param


What about .is_a? Integer

If Rails doesn't do any auto-conversion magic, level_param is always a String... but maybe it does, will try

Add /tournaments/:id/stages endpoint

5ea64ae

houndci-bot reviewed Oct 10, 2019

View reviewed changes

Thor77 changed the title ~~Add /tournaments/:id/stages endpoint~~ WIP: Add /tournaments/:id/stages endpoint Oct 10, 2019

Malaber reviewed Oct 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add /tournaments/:id/stages endpoint #70

WIP: Add /tournaments/:id/stages endpoint #70

Thor77 commented Oct 10, 2019 •

edited

Loading

houndci-bot Oct 10, 2019

Malaber Oct 10, 2019

Thor77 Oct 10, 2019

WIP: Add /tournaments/:id/stages endpoint #70

Are you sure you want to change the base?

WIP: Add /tournaments/:id/stages endpoint #70

Conversation

Thor77 commented Oct 10, 2019 • edited Loading

houndci-bot Oct 10, 2019

Choose a reason for hiding this comment

Malaber Oct 10, 2019

Choose a reason for hiding this comment

Thor77 Oct 10, 2019

Choose a reason for hiding this comment

Thor77 commented Oct 10, 2019 •

edited

Loading