fix(image,avatar): not trigger error event when set lazy only
#5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #5567 +/- ##
=======================================
Coverage 61.08% 61.08%
=======================================
Files 1107 1107
Lines 23618 23616 -2
Branches 6186 6184 -2
=======================================
Hits 14426 14426
+ Misses 7598 7596 -2
Partials 1594 1594 ☔ View full report in Codecov by Sentry. |
jizai1125
changed the title
lazy onlylazy only
jizai1125
force-pushed
the
fix/Image-not-trigger-error-event-in-lazy
branch
from
8fede04 to
df002c3
Compare
jizai1125
force-pushed
the
fix/Image-not-trigger-error-event-in-lazy
branch
from
df002c3 to
6b9c9e3
Compare
jizai1125
force-pushed
the
fix/Image-not-trigger-error-event-in-lazy
branch
from
fd30097 to
a2c638c
Compare
|
大佬~这个问题是不是暂时还没修复 |
还没合进版本，等作者合😄 |
好的捏 |
|
依旧没有合并？ |
明天我同步下代码，再问问作者 |
jizai1125
force-pushed
the
fix/Image-not-trigger-error-event-in-lazy
branch
from
a2c638c to
8e29b5b
Compare
|
@07akioni 大佬什么时候有空看下这个修复 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6110
lazy配合intersection-observer-options配置，使用 observe 实现的懒加载存在问题；改动的思路考虑了以下两种情况：document.documentElement改为了document根节点（应该要跟未指定 root 时一样吧，看了 w3c 的说明 intersectionobserver-intersection-root 未指定 root 默认也是 document 节点）；否则如果采用document.documentElement（指向 html 元素），html 元素的像素高度可能为 0（例如官方文档布局采用了绝对定位），导致entry.isIntersecting会永远为 true，图片不管是不是在浏览器视口内都会直接加载，采用 document 就解决了这个问题；