Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search history not loading on login #455

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

tusharlock10
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • App has been built and tested (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • PR is linked to the GitHub issue that is being addressed
  • Appropriate labels have been added to the PR

Type of PR

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactor
  • Build/ Workflow
  • Documentation
  • Other

Issue resolution

Tell us about how the fix/ feature resolves the linked issue

  • Search history is being loaded on login correctly
  • Fixed favouriteChampions api request being called when user is guest

Breaking change

If this is a breaking change (i.e. removing a feature, etc.) that could impact existing users

  • Yes
  • No

resolves #453

@tusharlock10 tusharlock10 added the fix Fixes a bug label Mar 11, 2024
@tusharlock10 tusharlock10 self-assigned this Mar 11, 2024
@tusharlock10 tusharlock10 merged commit 5f67cb5 into develop Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
Status: Closed PRs
Development

Successfully merging this pull request may close these issues.

1 participant