Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle boolean realtionship between hermes and pd #286

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Sep 11, 2024

Close #260

Technical Description

from Company to Organisation
in get_custom_field_val; added logic to convert the boolean to a string

from Organisation to Company
in company_dict in the cf_data_from_hermes
we check if cf type is a bool and convert the string to a bool

updated get_custom_fieldinfo so that the annotation of the TYPE_BOOL custom fields is optional bool or str

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.07%. Comparing base (63afdab) to head (950b85b).

Files with missing lines Patch % Lines
app/pipedrive/_schema.py 71.42% 1 Missing and 1 partial ⚠️
app/base_schema.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files          29       29              
  Lines        1884     1894      +10     
  Branches      296      300       +4     
==========================================
+ Hits         1697     1706       +9     
  Misses        135      135              
- Partials       52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 24, 2024

  • needs one more test to cover the .to_lower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass has_signed_up to pd
2 participants