Handle boolean realtionship between hermes and pd #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #260
Technical Description
from Company to Organisation
in
get_custom_field_val
; added logic to convert the boolean to a stringfrom Organisation to Company
in
company_dict
in thecf_data_from_hermes
we check if cf type is a bool and convert the string to a bool
updated
get_custom_fieldinfo
so that the annotation of the TYPE_BOOL custom fields is optional bool or str