Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made dropdown in navbar-expand absolute and assigned min width #41081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CJ-Pav
Copy link

@CJ-Pav CJ-Pav commented Dec 6, 2024

Description

I have this set to only apply to medium to large (in between) screen sizes. Added absolute, forced 200px minimum, limited application to md-lg screens because that's where the problem really exists.

Motivation & Context

The dropdown previously was taking over tablet screens. Simply was inefficient use of screen space. I understand the collapse navbar and it's great, but the dropdown forcing the navbar even lower than necessary for nav items was difficult especially as pages get larger. This way the navbar stays somewhat minimal. I didn't think the visual needed to change for small screens, but in hind sight it might look better to use this update on small screens as well. This could mean there is an easier way to implement this.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #41049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navbar-collapse used with dropdown-toggle
2 participants