Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-slides in the .slide-group. #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kitsunde
Copy link

The way the slider works right now is that it counts the children of the .slide-group even if those children are not .slide this include elements without size like <script>. This is incompatible with emberjs that injects script tags into the DOM to keep track of data binding. So if you do something like this:

<div class="slider">
    <div class="slide-group">
        {{#each}}
            <div class="slide">{{this}}</div>
        {{/each}}
    </div>
</div>

The DOM will look something like:

<div class="slider">
    <div class="slide-group">
        <script id="metamorph-11-start" type="text/x-placeholder"></script><script id="metamorph-14-start" type="text/x-placeholder"></script>
        <div class="slide">foo</div>
        <script id="metamorph-14-end" type="text/x-placeholder"></script><script id="metamorph-11-end" type="text/x-placeholder"></script>
    </div>
</div>

And the slider will think there's 3 slides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants