Remove linker error on windows in TweetNaCL #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite usual for C compilers to see every
.cfile as an entire translation unit (in fact that's how I view them as well). That means thattweetnacl.ccan't compile since we're not linking to any object file that provides therandombytesfunction.Apparently on Windows this is a thing.
This PR is a stopgap that prevents this annoying linker error from students finishing the exercise.
A remaining problem is that
sha256_tweetis not defined (due to macro-stuff intweetnacl.h), so as soon as someone starts playing around with this example (which we like) they're getting into a world of hurt as well.Best to switch away from something that is "academic" like tweetnacl.
Closes https://github.com/tweedegolf/rust-training-internal/issues/20