Navigation drawer scroll padding fix #9141
Conversation
ehconitin
changed the title
| @@ -106,11 +107,7 @@ export const ScrollWrapper = ({ | |||
| id: contextProviderName, | |||
| }} | |||
| > | |||
| <StyledScrollWrapper | |||
| ref={scrollableRef} | |||
| className={className} | |||
There was a problem hiding this comment.
why are we removing the scrollHide?
There was a problem hiding this comment.
We use scrollHide specifically to hide NavigationDrawer's scroll, but we have new requirements :). We are to show the scroll but with clear paddings
| ); | ||
| `; | ||
|
|
||
| export const NavigationDrawerSection = ({ |
There was a problem hiding this comment.
I don't understand all these changes? Looks big changes for a small fix, could you explain it a bit more?
There was a problem hiding this comment.
We can't just remove scrollHide and use the ScrollWrapper in the drawer since it overlaps over the NavigationDrawerItems(for reference #9026), so the idea is to remove the right padding of the NavigationDrawers animated container. And since NavigationDrawerSection controls the width, have an internal wrapper that would minus the width required for the scroll.
Is this the right approach? also, ignore the scroll paddings and widths being changed in ScrollWrapper, I was just trying something out!
closes #9026