refacto(auth): Simplify workspace lookup and cleanup UI logic #9160
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the horizontal separator visibility in the authentication form by correcting conditional rendering logic when SSO providers are disabled.
- Fixed logical error in
SignInUpGlobalScopeForm.tsxwhere{authProviders.google || (authProviders.microsoft && <HorizontalSeparator visible />)}incorrectly evaluates, causing separator to show when it shouldn't - Simplified workspace selection by defaulting to first available workspace instead of looking up default workspace ID
- Improved code readability by removing unnecessary whitespace and parentheses in conditional statements
- Added proper type checking for SSO providers array before mapping in
SignInUpSSOIdentityProviderSelection.tsx
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpGlobalScopeForm.tsx
Outdated
Show resolved
Hide resolved
Streamlined workspace selection by defaulting to the first available workspace. Adjusted conditional rendering for a separator between authentication providers, improving clarity and reducing redundancy. Minor formatting changes were also applied for consistency.
AMoreaux
force-pushed
the
fix/hide-separator-when-sso-is-disable
branch
from
09fa999 to
4f7d25d
Compare
AMoreaux
changed the title
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlined workspace selection by defaulting to the first available workspace. Adjusted conditional rendering for a separator between authentication providers, improving clarity and reducing redundancy. Minor formatting changes were also applied for consistency.
Close #9094