Fixed relations #9227
Merged
Fixed relations #9227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds eager loading of relations across field metadata validators and relation metadata hooks, ensuring consistent data loading patterns but potentially impacting performance.
- Fixed typo in
before-delete-one-relation.hook.tswhere 'fromFieldMetafata' needs to be corrected to 'fromFieldMetadata' - Added eager loading of relations in
is-field-metadata-options.validator.tsandis-field-metadata-default-value.validator.tswhich may be unnecessary since only 'type' field is used - Added 'fromObjectMetadata' and 'toObjectMetadata' relations to eager loading in
before-delete-one-relation.hook.ts
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...src/engine/metadata-modules/field-metadata/validators/is-field-metadata-options.validator.ts
Outdated
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/relation-metadata/hooks/before-delete-one-relation.hook.ts
Outdated
Show resolved
Hide resolved
...gine/metadata-modules/field-metadata/validators/is-field-metadata-default-value.validator.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Dec 24, 2024
...gine/metadata-modules/field-metadata/validators/is-field-metadata-default-value.validator.ts
Outdated
Show resolved
Hide resolved
...src/engine/metadata-modules/field-metadata/validators/is-field-metadata-options.validator.ts
Outdated
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/relation-metadata/hooks/before-delete-one-relation.hook.ts
Outdated
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/relation-metadata/hooks/before-delete-one-relation.hook.ts
Outdated
Show resolved
Hide resolved
Weiko
approved these changes
Dec 24, 2024
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Follow-up : Fixed relations eager load on refactored hooks from PR twentyhq#8695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up : Fixed relations eager load on refactored hooks from PR #8695