-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][FRONT] Storybook tests sharding and build optimization #9448
Conversation
0ae4f91
to
84f813e
Compare
d553606
to
d7988e1
Compare
3cb5887
to
5403a56
Compare
This reverts commit 42c4352.
ff51940
to
c11b546
Compare
280ab4e
to
f7ad85b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Implemented comprehensive Storybook test sharding and caching optimizations to improve CI performance and build times.
- Added 4-way test sharding in
.github/workflows/ci-front.yaml
with separate coverage artifacts for each shard - Optimized Storybook build caching using
actions/cache/restore
andactions/cache/save
with SHA-based keys - Added
--test
flag to Storybook builds innx.json
to disable docs plugins during testing - Configured test scopes (modules/pages/performance) to run in parallel with sharding support
- Added coverage report merging step to combine results from sharded test runs
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
77673b0
to
36d796b
Compare
Log
|
Introduction
The idea here is to improve perf nor fluidity of both storybook build and tests execution duration.
Levers:
actions/cache/restore
andactions/cache/save
to avoid useless computation with we wanna just write or retrieve itcloses twentyhq/core-team-issues#49