Finalize the readonly for a few form fields #1 #9524
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devessier
force-pushed
the
complete-workflow-fields-readonly
branch
from
3cf42c8 to
893fd35
Compare
This introduces a "non-deletable" mode. I forked the SortOrFilterChip component to not make unrelated changes in this component.
Devessier
force-pushed
the
complete-workflow-fields-readonly
branch
from
893fd35 to
1ced6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many fields so I will cut my work in several small PRs.
Here, I updated the following fields:
FormBooleanFieldInputFormCurrencyFieldInputFormNumberFieldInputFormDateFieldInputFormDateTimeFieldInputFormMultiSelectFieldInputFormSelectFieldInputThe updates in the components are relatively small. I wrote Storybook tests, and this is why the PR is quite big.
The changes in the components should mostly the same.
I added a disabled state to some inputs.
I created a specialized
VariableChipas its styles started diverging from the originalSortOrFilterChip.