fix NumberFormatter::TYPE_CURRENCY being deprecated in PHP 8.3
#3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mbolli. |
|
@fabpot Can you please tag this? PHP 8.3 will be released in 2 days. Thanks a lot! 😄 |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Dec 28, 2023
…tant (javiereguiluz) This PR was merged into the 4.x branch. Discussion ---------- Remove the deprecated NumberFormatter::TYPE_CURRENCY constant Fixes #6071. I saw this from Twig project --> twigphp/Twig#3894 Given that they just removed it because it's unused and given that we copied this code from that project, let's just remove it too. Commits ------- 904f10e Remove the deprecated NumberFormatter::TYPE_CURRENCY constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never used anyway (by Twig and by PHP), so removing it should not have any side-effects.