Ignore exceptions from undefined handlers when using the guard tag #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
guard-fix-exception
branch
from
1e05a3c to
7a473c6
Compare
stof
reviewed
Dec 19, 2024
fabpot
force-pushed
the
guard-fix-exception
branch
from
7a473c6 to
b53c639
Compare
stof
approved these changes
Dec 19, 2024
|
Thanks for merging this and for releasing it as part of Twig 3.18.0. Sadly, this change didn't fix the issue for me. See the failing tests: https://github.com/EasyCorp/EasyAdminBundle/actions/runs/12550268707 |
|
The reason for the failure Javier observes (and also the reason for #4528 (comment)) is that the following |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4505