Add invoke filter #4518
Merged
Add invoke filter #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Dec 27, 2024
smnandre
reviewed
Dec 28, 2024
|
This change also deserves an entry in the changelog for 3.19.0. |
|
@xabbuh, I can add that. What about the documentation? Should I also add a page to the filter reference in the docs? And mention it in the section about arrow functions? Or do you have something different in mind? |
|
Doing what you suggested looks good to me. |
fabpot
requested changes
Jan 1, 2025
GromNaN
reviewed
Jan 7, 2025
xabbuh
reviewed
Jan 7, 2025
fabpot
requested changes
Jan 8, 2025
xabbuh
reviewed
Jan 9, 2025
fabpot
reviewed
Jan 9, 2025
Co-authored-by: Christian Flothmann <[email protected]>
Co-authored-by: Fabien Potencier <[email protected]>
|
Thank you @Lorenzschaef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter
invoke, to invoke arrow functions and other php callables.See the discussion here: #4378 (comment)