Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): log polling backs off when it doesn't receive results #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philnash
Copy link
Contributor

Fixes #251

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel July 12, 2021 06:09
@dkundel
Copy link
Member

dkundel commented Jul 14, 2021

What happens if we back off and then lots of logs (more than one page) get generated between the next poll. It doesn't look like we would currently fetch those again is that correct?

@philnash
Copy link
Contributor Author

In the serverless-api methods we don't expose the pagination, so I had to write a new function for this particular method (to avoid changing results and making a breaking change).

Might it be worth changing the list methods for the resources here to expose pagination so that external modules can choose one or multiple pages when they use this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement back off for logs streaming
2 participants