feat: Public OAuth uptake for C# libraries #762
Conversation
|
| #if NET35 | ||
| return IsTokenExpired(accessToken); | ||
| #else | ||
| return isTokenExpired(accessToken); | ||
| #endif |
There was a problem hiding this comment.
Do we have any function that works in both old and new framework? instead of making two different functions, if we can use single one to do it?
There was a problem hiding this comment.
we cannot use single function to do it, whatever works in 3.5 is deprecated in later versions and vice versa
| @@ -116,7 +125,7 @@ public Response Request(Request request) | |||
| catch (Exception clientException) | |||
| { | |||
| throw new ApiConnectionException( | |||
| "Connection Error: " + request.Method + request.ConstructUrl(), | |||
| "Connection Error1: " + request.Method + request.ConstructUrl(), | |||
There was a problem hiding this comment.
Do we need to do Error1 here or is it a debug statement? Please check once
| { | ||
| throw new AuthenticationException("ClientId or ClientSecret cannot be null"); | ||
| } | ||
| grantType = "client_credentials"; |
There was a problem hiding this comment.
It should be this.grantType I guess
Fixes
DII-1683
A short description of what this PR does.
Public OAuth uptake for C# libraries
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.