fix: go enum schema changes #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childish-sambino
approved these changes
Jul 14, 2022
| private Map<String, ModelsMap> filterOutEnumResults( Map<String, ModelsMap> results) { | ||
| HashMap <String, ModelsMap> resultMap = new HashMap<>(); | ||
| results.forEach((key ,value) -> { | ||
| if (!key.contains("_enum_")) { |
There was a problem hiding this comment.
Is there a ticket in the backlog to revisit this?
There was a problem hiding this comment.
Nope, We will create it tomorrow and we will also create other improvement tickets for preview and alternative approach to enum name in OAI schema models
| String[] value = property.dataType.split("Enum"); | ||
| property.datatypeWithEnum = value[value.length-1]; | ||
| property.dataType = "string"; | ||
| property.isEnum = property.dataType == null;; |
There was a problem hiding this comment.
This would always be false.
There was a problem hiding this comment.
Yes, This should be property.isEnum = property.dataFormat == null;; Will fix it before merging
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Added support to parse enum changes added in OAI spec for go as part of the PR: twilio/twilio-oai#71
updated to spec file for related enum changes
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.