Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding mock server and test case to verify http timeout #649

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AsabuHere
Copy link
Contributor

@AsabuHere AsabuHere commented Apr 25, 2023

Fixes

DII-933 Adding test case to test http global timeout
A short description of what this PR does.
Adding test case to test http global timeout

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@AsabuHere AsabuHere changed the title fix: Adding mock server for ruby testing and test case to verify http time… fix: Adding mock server and test case to verify http timeout Apr 25, 2023
@@ -0,0 +1,81 @@
require 'minitest/autorun'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why there's a separate testcases folder? Don't think these tests would be picked up with the automated test runs, the test command follows a pattern that picks up the files in spec folder with filename ending with _spec.rb. Anything else, doesn't run.

Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment posted earlier needs to be resolved. If we are not prioritising this right now, lets turn it into a draft PR, since some work is done on this.

@AsabuHere AsabuHere marked this pull request as draft May 8, 2023 08:29
@AsabuHere
Copy link
Contributor Author

The comment posted earlier needs to be resolved. If we are not prioritising this right now, lets turn it into a draft PR, since some work is done on this.

We are not prioritising this right now, converted this to a draft PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants