This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Feature/add auth module #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HosokawaR
reviewed
Sep 19, 2023
takonomura
suggested changes
Sep 20, 2023
| Value: session.ID.String(), | ||
| Path: "/", | ||
| Expires: session.ExpiredAt, | ||
| HttpOnly: true, |
There was a problem hiding this comment.
環境変数から指定できるように修正します。
api/oauth2/handler.go
Outdated
| queryState := r.URL.Query().Get("state") | ||
|
|
||
| if cookieState == "" || queryState == "" || cookieState != queryState { | ||
| http.Error(w, err.Error(), http.StatusInternalServerError) |
api/oauth2/handler.go
Outdated
| case "google": | ||
| provider = authentity.ProviderGoogle | ||
| default: | ||
| http.Error(w, "invalid provider", http.StatusInternalServerError) |
There was a problem hiding this comment.
Internal Server Error ではなさそう。
ここ以外も同じように見直したほうが良いように思います。
api/interceptor/auth.go
Outdated
Comment on lines
22
to
27
| if err == nil { | ||
| return next(ctx, req) | ||
| } | ||
|
|
||
| sessionID, err := idtype.NewSessionIDFromString(cookie.Value) | ||
| if err == nil { |
There was a problem hiding this comment.
逆じゃないですか?
Suggested change
| if err == nil { | |
| return next(ctx, req) | |
| } | |
| sessionID, err := idtype.NewSessionIDFromString(cookie.Value) | |
| if err == nil { | |
| if err != nil { | |
| return next(ctx, req) | |
| } | |
| sessionID, err := idtype.NewSessionIDFromString(cookie.Value) | |
| if err != nil { |
module/auth/gateway/google.go
Outdated
| "google.golang.org/api/option" | ||
| ) | ||
|
|
||
| //go:embed google_client_credentials.json |
There was a problem hiding this comment.
これビルド時に差し込む形になっちゃうのでやめてください。
client_id と client_secret を環境変数でもらうような形にしてください。
| } | ||
|
|
||
| func (h *Handler) HandleLogout(w http.ResponseWriter, r *http.Request) { | ||
| user, err := h.authUseCase.AuthorizeAuthenticatedUser(r.Context()) |
There was a problem hiding this comment.
ここでこれって動くんですか? Connect でしか処理してない気がする。
There was a problem hiding this comment.
動かないですね。別途middlewareを定義しようと思います。
|
お二人ともレビューありがとうございます！ TODO
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth moduleを追加しました。
このモジュールでは主に下記のことを行なっています。